Comments for Brent Says...

Comment on WPF DataGridRow Double Click With MVVM by miliu

miliu — Thu, 21 Mar 2013 12:50:07 +0000

Thanks for sharing. Your approach works, but I tried WiiMaxx’s suggestion and it works too. I believe WiiMaxx’s approach is a better way to do it.

Comment on Dynamic WHERE Clause with SQL Server Stored Procedure by William Beckett

William Beckett — Wed, 13 Mar 2013 20:39:46 +0000

This is one of the most amazing tricks I have ever came across in my life. Thank you so very much!!!! I can’t believe how well it works!!!

Comment on WPF DataGridRow Double Click With MVVM by Gianfranco

Gianfranco — Wed, 27 Feb 2013 20:33:49 +0000

Thank you! this solution can solve many situations..

Comment on WPF DataGridRow Double Click With MVVM by WiiMaxx

WiiMaxx — Thu, 07 Feb 2013 15:48:31 +0000

nice my xaml got trimed i hoppe this will work now …
&lg DataGrid.InputBindings>
&lg MouseBinding Gesture=”LeftDoubleClick” Command=”{Binding EditCommand}”/>
&lg KeyBinding Key=”Enter” Command=”{Binding EditCommand}”/>
&lg/DataGrid.InputBindings>

Comment on WPF DataGridRow Double Click With MVVM by WiiMaxx

WiiMaxx — Thu, 07 Feb 2013 15:43:05 +0000

better way to do this in MVVM xaml part: VM part: private RelayCommand _editCommand; public ICommand EditCommand { get { return _editCommand ?? (_editCommand = new RelayCommand(param => this.canEdit, param => this.Edit())); } } and it works RelayCommand <- use her your own interpretation

Comment on WPF DataGridRow Double Click With MVVM by Shah

Shah — Tue, 27 Nov 2012 19:10:15 +0000

Nice work.. Problem Solved. Thnaks for sharing.

Comment on Roll Your Own Simple Message Bus / Event Aggregator by Ilia Jerebtsov

Ilia Jerebtsov — Thu, 02 Aug 2012 16:10:10 +0000

Hmm, I’m not entirely sure you have. Even though you’re wrapping action.Target with a WeakReference, you’re also keeping a strong reference to the action itself in the ActionReference.Target property. This defeats the point, as you’ll always have that reference keeping it alive and uncollectable.

Comment on Roll Your Own Simple Message Bus / Event Aggregator by Brent Edwards

Brent Edwards — Thu, 02 Aug 2012 03:29:01 +0000

@Ilia, you are absolutely right. I have addressed that with the message bus implementation for MVVM Fabric: https://github.com/brentedwards/MvvmFabric/tree/master/MvvmFabric/Messaging

Comment on Roll Your Own Simple Message Bus / Event Aggregator by Ilia Jerebtsov

Ilia Jerebtsov — Tue, 31 Jul 2012 14:33:49 +0000

This straightforward approach has one important caveat. When you register a handler into the message bus, you’re keeping a reference to the subscriber. This means that if the subscriber fails to unsubscribe when it’s done receiving messages, the instance will not be garbage collected until the message bus is.

If your bus is a singleton that exists for the duration of the application, this might cause your subscribers not to get collected in a timely fashion. This is only tolerable if the number of subscribers is small and bounded.

Even if you are diligent to unsubscribe whenever your objects are disposed, you’ve defeated the point of automatic memory management.

A solution that doesn’t have this caveat will need to use WeakReferences to avoid holding on to the subscribers.

Comment on Roll Your Own Simple Message Bus / Event Aggregator by Grigory

Grigory — Wed, 06 Jun 2012 21:53:35 +0000

Hi, nice implementation.
Found minor issue
Unsubscribing in handler leads to exception(changing collection during iteration)
Solutions:
1. Adding SubscribeOnce method (which is usefull anyway)
2. In Publish method iterating over copied collection.